RPJosh
/
authelia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[CI] Adjust reviewdog filtermode for linting (#1506) 

This will ensure that linter errors are picked up for the entire codebase instead of just against the default of [added/modified lines](https://github.com/reviewdog/reviewdog#added-default).
pull/1507/head
Amir Zarrinkafsh 2020-12-03 18:06:42 +11:00 committed by GitHub
parent 426f5260ad
commit 0bf192aae0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.buildkite/pipeline.sh
View File

@ -27,7 +27,7 @@ env:
steps: steps:
- label: ":service_dog: Linting" - label: ":service_dog: Linting"
command: "reviewdog -reporter=github-check -fail-on-error" command: "reviewdog -reporter=github-check -filter-mode=nofilter -fail-on-error"
retry: retry:
automatic: true automatic: true
if: build.branch !~ /^(v[0-9]+\.[0-9]+\.[0-9]+)$\$/ if: build.branch !~ /^(v[0-9]+\.[0-9]+\.[0-9]+)$\$/

16
internal/configuration/validator/authentication_test.go
View File

@ -160,10 +160,10 @@ func (suite *LdapAuthenticationBackendSuite) SetupTest() {
suite.configuration = schema.AuthenticationBackendConfiguration{} suite.configuration = schema.AuthenticationBackendConfiguration{}
suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{} suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{}
suite.configuration.Ldap.Implementation = schema.LDAPImplementationCustom suite.configuration.Ldap.Implementation = schema.LDAPImplementationCustom
suite.configuration.Ldap.URL = "ldap://ldap" suite.configuration.Ldap.URL = testLDAPURL
suite.configuration.Ldap.User = "user" suite.configuration.Ldap.User = testLDAPUser
suite.configuration.Ldap.Password = "password" suite.configuration.Ldap.Password = testLDAPPassword
suite.configuration.Ldap.BaseDN = "base_dn" suite.configuration.Ldap.BaseDN = testLDAPBaseDN
suite.configuration.Ldap.UsernameAttribute = "uid" suite.configuration.Ldap.UsernameAttribute = "uid"
suite.configuration.Ldap.UsersFilter = "({username_attribute}={input})" suite.configuration.Ldap.UsersFilter = "({username_attribute}={input})"
suite.configuration.Ldap.GroupsFilter = "(cn={input})" suite.configuration.Ldap.GroupsFilter = "(cn={input})"
@ -340,10 +340,10 @@ func (suite *ActiveDirectoryAuthenticationBackendSuite) SetupTest() {
suite.configuration = schema.AuthenticationBackendConfiguration{} suite.configuration = schema.AuthenticationBackendConfiguration{}
suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{} suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{}
suite.configuration.Ldap.Implementation = schema.LDAPImplementationActiveDirectory suite.configuration.Ldap.Implementation = schema.LDAPImplementationActiveDirectory
suite.configuration.Ldap.URL = "ldap://ldap" suite.configuration.Ldap.URL = testLDAPURL
suite.configuration.Ldap.User = "user" suite.configuration.Ldap.User = testLDAPUser
suite.configuration.Ldap.Password = "password" suite.configuration.Ldap.Password = testLDAPPassword
suite.configuration.Ldap.BaseDN = "base_dn" suite.configuration.Ldap.BaseDN = testLDAPBaseDN
} }
func (suite *ActiveDirectoryAuthenticationBackendSuite) TestShouldSetActiveDirectoryDefaults() { func (suite *ActiveDirectoryAuthenticationBackendSuite) TestShouldSetActiveDirectoryDefaults() {

6
internal/configuration/validator/const.go
View File

@ -167,7 +167,11 @@ const schemeLDAP = "ldap"
const schemeLDAPS = "ldaps" const schemeLDAPS = "ldaps"
const testBadTimer = "-1" const testBadTimer = "-1"
const testModeDisabled = "disable"
const testJWTSecret = "a_secret" const testJWTSecret = "a_secret"
const testLDAPBaseDN = "base_dn"
const testLDAPPassword = "password"
const testLDAPURL = "ldap://ldap"
const testLDAPUser = "user"
const testModeDisabled = "disable"
const testTLSCert = "/tmp/cert.pem" const testTLSCert = "/tmp/cert.pem"
const testTLSKey = "/tmp/key.pem" const testTLSKey = "/tmp/key.pem"