diff --git a/.buildkite/pipeline.sh b/.buildkite/pipeline.sh index e9f518660..f7f485336 100755 --- a/.buildkite/pipeline.sh +++ b/.buildkite/pipeline.sh @@ -27,7 +27,7 @@ env: steps: - label: ":service_dog: Linting" - command: "reviewdog -reporter=github-check -fail-on-error" + command: "reviewdog -reporter=github-check -filter-mode=nofilter -fail-on-error" retry: automatic: true if: build.branch !~ /^(v[0-9]+\.[0-9]+\.[0-9]+)$\$/ diff --git a/internal/configuration/validator/authentication_test.go b/internal/configuration/validator/authentication_test.go index fcb9aad63..7da18d0dc 100644 --- a/internal/configuration/validator/authentication_test.go +++ b/internal/configuration/validator/authentication_test.go @@ -160,10 +160,10 @@ func (suite *LdapAuthenticationBackendSuite) SetupTest() { suite.configuration = schema.AuthenticationBackendConfiguration{} suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{} suite.configuration.Ldap.Implementation = schema.LDAPImplementationCustom - suite.configuration.Ldap.URL = "ldap://ldap" - suite.configuration.Ldap.User = "user" - suite.configuration.Ldap.Password = "password" - suite.configuration.Ldap.BaseDN = "base_dn" + suite.configuration.Ldap.URL = testLDAPURL + suite.configuration.Ldap.User = testLDAPUser + suite.configuration.Ldap.Password = testLDAPPassword + suite.configuration.Ldap.BaseDN = testLDAPBaseDN suite.configuration.Ldap.UsernameAttribute = "uid" suite.configuration.Ldap.UsersFilter = "({username_attribute}={input})" suite.configuration.Ldap.GroupsFilter = "(cn={input})" @@ -340,10 +340,10 @@ func (suite *ActiveDirectoryAuthenticationBackendSuite) SetupTest() { suite.configuration = schema.AuthenticationBackendConfiguration{} suite.configuration.Ldap = &schema.LDAPAuthenticationBackendConfiguration{} suite.configuration.Ldap.Implementation = schema.LDAPImplementationActiveDirectory - suite.configuration.Ldap.URL = "ldap://ldap" - suite.configuration.Ldap.User = "user" - suite.configuration.Ldap.Password = "password" - suite.configuration.Ldap.BaseDN = "base_dn" + suite.configuration.Ldap.URL = testLDAPURL + suite.configuration.Ldap.User = testLDAPUser + suite.configuration.Ldap.Password = testLDAPPassword + suite.configuration.Ldap.BaseDN = testLDAPBaseDN } func (suite *ActiveDirectoryAuthenticationBackendSuite) TestShouldSetActiveDirectoryDefaults() { diff --git a/internal/configuration/validator/const.go b/internal/configuration/validator/const.go index 5e7ee5d6c..acbdea81a 100644 --- a/internal/configuration/validator/const.go +++ b/internal/configuration/validator/const.go @@ -167,7 +167,11 @@ const schemeLDAP = "ldap" const schemeLDAPS = "ldaps" const testBadTimer = "-1" -const testModeDisabled = "disable" const testJWTSecret = "a_secret" +const testLDAPBaseDN = "base_dn" +const testLDAPPassword = "password" +const testLDAPURL = "ldap://ldap" +const testLDAPUser = "user" +const testModeDisabled = "disable" const testTLSCert = "/tmp/cert.pem" const testTLSKey = "/tmp/key.pem"