RPJosh
/
neatvnc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http: Stop memory leak in failure path

pull/68/head
Andri Yngvason 2023-04-30 14:29:30 +00:00
parent 1fa8d41aef
commit 2f439b9fa2
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/http.c
View File

@ -473,7 +473,6 @@ static int http__header(struct http_req* req, struct httplex* lex)
int http_req_parse(struct http_req* req, const char* input) int http_req_parse(struct http_req* req, const char* input)
{ {
int rc = -1;
memset(req, 0, sizeof(*req)); memset(req, 0, sizeof(*req));
struct httplex lex; struct httplex lex;
@ -488,17 +487,20 @@ int http_req_parse(struct http_req* req, const char* input)
req->header_length = lex.next_pos - input; req->header_length = lex.next_pos - input;
rc = 0; httplex_destroy(&lex);
return 0;
failure: failure:
httplex_destroy(&lex); httplex_destroy(&lex);
return rc; http_req_free(req);
return -1;
} }
void http_req_free(struct http_req* req) void http_req_free(struct http_req* req)
{ {
free(req->content_type); free(req->content_type);
for (size_t i = 0; i < req->field_index; ++i) { for (size_t i = 0; i < HTTP_FIELD_INDEX_MAX && req->field[i].key; ++i) {
free(req->field[i].key); free(req->field[i].key);
free(req->field[i].value); free(req->field[i].value);
} }