RPJosh
/
neatvnc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up some memory leaks

tight-png
Andri Yngvason 2019-12-27 15:07:48 +00:00
parent 875cd5af7b
commit 00450e0c9d
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/server.c
View File

@ -719,12 +719,12 @@ static void on_client_read(uv_stream_t* stream, ssize_t n_read,
(uv_tcp_t*)stream, struct nvnc_client, stream_handle); (uv_tcp_t*)stream, struct nvnc_client, stream_handle);
if (n_read == 0) if (n_read == 0)
return; goto done;
if (n_read < 0) { if (n_read < 0) {
uv_read_stop(stream); uv_read_stop(stream);
client_unref(client); client_unref(client);
return; goto done;
} }
assert(client->buffer_index == 0); assert(client->buffer_index == 0);
@ -734,7 +734,7 @@ static void on_client_read(uv_stream_t* stream, ssize_t n_read,
client->state = VNC_CLIENT_STATE_ERROR; client->state = VNC_CLIENT_STATE_ERROR;
uv_read_stop(stream); uv_read_stop(stream);
client_unref(client); client_unref(client);
return; goto done;
} }
memcpy(client->msg_buffer + client->buffer_len, buf->base, n_read); memcpy(client->msg_buffer + client->buffer_len, buf->base, n_read);
@ -754,6 +754,9 @@ static void on_client_read(uv_stream_t* stream, ssize_t n_read,
client->buffer_index); client->buffer_index);
client->buffer_len -= client->buffer_index; client->buffer_len -= client->buffer_index;
client->buffer_index = 0; client->buffer_index = 0;
done:
free(buf->base);
} }
static void on_connection(uv_stream_t* server_stream, int status) static void on_connection(uv_stream_t* server_stream, int status)
@ -932,6 +935,9 @@ void on_client_update_fb_done(uv_work_t* work, int status)
process_fb_update_requests(client); process_fb_update_requests(client);
nvnc_fb_unref(update->fb); nvnc_fb_unref(update->fb);
client_unref(client); client_unref(client);
pixman_region_fini(&update->region);
free(update);
} }
int schedule_client_update_fb(struct nvnc_client* client) int schedule_client_update_fb(struct nvnc_client* client)