RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

video: transcode all live photos (fix #388)

pull/417/head
Varun Patil 2023-02-11 08:19:46 -08:00
parent 681eb1da9c
commit fc12219695
1 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/Controller/VideoController.php
View File

@ -115,8 +115,9 @@ class VideoController extends ApiBase
// Response data
$name = '';
$blob = null;
$mime = '';
$blob = null;
$liveVideoPath = null;
// Video is inside the file
$path = null;
@ -172,15 +173,7 @@ class VideoController extends ApiBase
$name = $liveFile->getName();
$blob = $liveFile->getContent();
$mime = $liveFile->getMimeType();
if ($transcode && !$this->config->getSystemValue('memories.no_transcode', true)) {
// Only Apple uses HEVC for now, so pass this to the transcoder
// If this is H.264 it won't get transcoded anyway
$liveVideoPath = $liveFile->getStorage()->getLocalFile($liveFile->getInternalPath());
if ($this->getUpstream($transcode, $liveVideoPath, 'max.mov')) {
exit;
}
}
$liveVideoPath = $liveFile->getStorage()->getLocalFile($liveFile->getInternalPath());
}
}
@ -189,6 +182,24 @@ class VideoController extends ApiBase
return new JSONResponse(['message' => 'Live file not found'], Http::STATUS_NOT_FOUND);
}
// Transcode video if allowed
if ($transcode && !$this->config->getSystemValue('memories.no_transcode', true)) {
// If video path not given, write to temp file
if (!$liveVideoPath) {
$liveVideoPath = tempnam(sys_get_temp_dir(), 'livevideo');
file_put_contents($liveVideoPath, $blob);
register_shutdown_function(function () use ($liveVideoPath) {
unlink($liveVideoPath);
});
}
// If this is H.264 it won't get transcoded anyway
if ($this->getUpstream($transcode, $liveVideoPath, 'max.mov')) {
exit;
}
}
// Make and send response
$response = new DataDisplayResponse($blob, Http::STATUS_OK, []);
$response->setHeaders([