RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix image fade on cache miss

pull/37/head
Varun Patil 2022-09-09 19:36:40 -07:00
parent f5337cb990
commit f92dfb5e95
3 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/memories-main.js
View File

File diff suppressed because one or more lines are too long

2
js/memories-main.js.map
View File

File diff suppressed because one or more lines are too long

18
src/components/Photo.vue
View File

@ -47,6 +47,7 @@ export default {
return { return {
touchTimer: 0, touchTimer: 0,
c: constants, c: constants,
prevUrl: undefined,
} }
}, },
props: { props: {
@ -66,13 +67,24 @@ export default {
methods: { methods: {
/** Get URL for image to show */ /** Get URL for image to show */
getUrl() { getUrl() {
let url;
if (this.data.flag & constants.FLAG_PLACEHOLDER) { if (this.data.flag & constants.FLAG_PLACEHOLDER) {
return undefined; url = undefined;
} else if (this.data.flag & constants.FLAG_LOAD_FAIL) { } else if (this.data.flag & constants.FLAG_LOAD_FAIL) {
return generateUrl('apps/memories/img/error.svg'); url = generateUrl('apps/memories/img/error.svg');
} else { } else {
return getPreviewUrl(this.data.fileid, this.data.etag); url = getPreviewUrl(this.data.fileid, this.data.etag);
} }
// Store the current URL and reset the loaded flag if different
// This is useful if the component is recycled and/or if
// a cache miss occurs
if (url !== this.prevUrl) {
this.prevUrl = url;
this.data.flag &= ~constants.FLAG_LOADED;
}
return url;
}, },
/** Error in loading image */ /** Error in loading image */