RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: get rid of timeline scroll funcs

old-stable24
Varun Patil 2022-10-19 15:54:20 -07:00
parent 005d590ac5
commit c0cf85e9a8
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/components/Timeline.vue
View File

@ -403,18 +403,6 @@ export default class Timeline extends Mixins(GlobalMixin, UserConfig) {
} }
} }
/** Store the current scroll position to restore later */
private getScrollY() {
const recycler = this.$refs.recycler as any;
return recycler.$el.scrollTop
}
/** Restore the stored scroll position */
private setScrollY(y: number) {
const recycler = this.$refs.recycler as any;
recycler.scrollToPosition(y);
}
/** Get query string for API calls */ /** Get query string for API calls */
appendQuery(url: string) { appendQuery(url: string) {
const query = new URLSearchParams(); const query = new URLSearchParams();
@ -793,9 +781,6 @@ export default class Timeline extends Mixins(GlobalMixin, UserConfig) {
const headIdx = this.list.findIndex(item => item.id === head.id); const headIdx = this.list.findIndex(item => item.id === head.id);
let rowIdx = headIdx + 1; let rowIdx = headIdx + 1;
// Store the scroll position in case we change any rows
const scrollY = this.getScrollY();
// Previous justified row // Previous justified row
let prevJustifyTop = justify[0]?.top || 0; let prevJustifyTop = justify[0]?.top || 0;
@ -922,7 +907,7 @@ export default class Timeline extends Mixins(GlobalMixin, UserConfig) {
const recycler: any = this.$refs.recycler; const recycler: any = this.$refs.recycler;
const midIndex = (recycler.$_startIndex + recycler.$_endIndex) / 2; const midIndex = (recycler.$_startIndex + recycler.$_endIndex) / 2;
if (midIndex > headIdx) { if (midIndex > headIdx) {
this.setScrollY(scrollY + rowSizeDelta); recycler.$el.scrollTop += rowSizeDelta;
} }
} }
} }