From 94e9b616d29c0637c57282834c74c9929019f40b Mon Sep 17 00:00:00 2001
From: Leandro Lucarella <luca@llucax.com>
Date: Sun, 23 Apr 2023 11:53:38 +0200
Subject: [PATCH] Avoid showing "Memories: Indexing process stopped before
 completion. Will continue on next run" as a warning

An indexing cron job not finishing is just normal operation, so
we shouldn't emit a warning for it. This commit emits a info
instead when this happens.

While we are at it, we also emit a info message if the indexing
was successful.
---
 lib/Cron/IndexJob.php | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/Cron/IndexJob.php b/lib/Cron/IndexJob.php
index 0fc391f4..55c1a175 100644
--- a/lib/Cron/IndexJob.php
+++ b/lib/Cron/IndexJob.php
@@ -63,7 +63,7 @@ class IndexJob extends TimedJob
             $this->indexAllUsers();
             $this->log('Indexing completed successfully', 'success');
         } catch (Service\ProcessClosedException $e) {
-            $this->log('Indexing process stopped before completion. Will continue on next run', 'warning');
+            $this->log('Indexing process stopped before completion. Will continue on next run', 'info');
         } finally {
             \OCA\Memories\Exif::closeStaticExiftoolProc();
         }
@@ -95,6 +95,11 @@ class IndexJob extends TimedJob
 
     private function log(string $msg, string $type = 'error'): void
     {
+        if ('success' === $type || 'info' === $type) {
+            // If this is just an informational message, we log it with level info
+            $this->logger->info('Memories: '.$msg);
+        }
+
         if ($this->_hasError && 'success' === $type) {
             // Don't overwrite an error with a success
             return;
@@ -103,9 +108,7 @@ class IndexJob extends TimedJob
         $this->config->setAppValue(Application::APPNAME, 'last_index_job_status', $msg);
         $this->config->setAppValue(Application::APPNAME, 'last_index_job_status_type', $type);
 
-        if ('success' === $type) {
-            // Nothing
-        } elseif ('warning' === $type) {
+        if ('warning' === $type) {
             $this->logger->warning('Memories: '.$msg);
         } elseif ('error' === $type) {
             $this->_hasError = true;