RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

timeline: fix destructive cache reads 

Signed-off-by: Varun Patil <radialapps@gmail.com>
pull/807/merge
Varun Patil 2023-10-03 09:31:03 -07:00
parent e4ca88462d
commit 5f6897b5c9
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/components/Timeline.vue
View File

@ -146,6 +146,8 @@ export default defineComponent({
numCols: 0, numCols: 0,
/** Header rows for dayId key */ /** Header rows for dayId key */
heads: {} as { [dayid: number]: IHeadRow }, heads: {} as { [dayid: number]: IHeadRow },
/** Current list (days response) was loaded from cache */
daysIsCache: false,
/** Size of outer container [w, h] */ /** Size of outer container [w, h] */
containerSize: [0, 0] as [number, number], containerSize: [0, 0] as [number, number],
@ -694,7 +696,7 @@ export default defineComponent({
cache = nativex.mergeDays(cache, await nativex.getLocalDays()); cache = nativex.mergeDays(cache, await nativex.getLocalDays());
} }
await this.processDays(cache); await this.processDays(cache, true);
this.updateLoading(-1); this.updateLoading(-1);
} }
} catch { } catch {
@ -719,7 +721,7 @@ export default defineComponent({
// Make sure we're still on the same page // Make sure we're still on the same page
if (this.state !== startState) return; if (this.state !== startState) return;
await this.processDays(data); await this.processDays(data, false);
} catch (e) { } catch (e) {
if (!utils.isNetworkError(e)) { if (!utils.isNetworkError(e)) {
showError(e?.response?.data?.message ?? e.message); showError(e?.response?.data?.message ?? e.message);
@ -731,8 +733,12 @@ export default defineComponent({
} }
}, },
/** Process the data for days call including folders */ /**
async processDays(data: IDay[]) { * Process the data for days call including folders
* @param data Days data
* @param cache Whether the data was from cache
*/
async processDays(data: IDay[], cache: boolean) {
if (!data || !this.state) return; if (!data || !this.state) return;
const list: typeof this.list = []; const list: typeof this.list = [];
@ -824,6 +830,9 @@ export default defineComponent({
this.loadedDays.clear(); this.loadedDays.clear();
this.sizedDays.clear(); this.sizedDays.clear();
// Mark if the data was from cache
this.daysIsCache = cache;
// Iterate the preload map // Iterate the preload map
// Now the inner detail objects are reactive // Now the inner detail objects are reactive
for (const dayId in preloads) { for (const dayId in preloads) {
@ -877,10 +886,20 @@ export default defineComponent({
// Process the cache // Process the cache
utils.removeHiddenPhotos(cache); utils.removeHiddenPhotos(cache);
// If this is a cached response and the list is not, then we don't
// want to take any destructive actions like removing a day.
// 1. If a day is removed then it will not be fetched again
// 2. But it probably does exist on the server
// 3. Since days could be fetched, the user probably is connected
if (!this.daysIsCache && !cache.length) {
throw new Error('Skipping empty cache because view is fresh');
}
this.processDay(dayId, cache); this.processDay(dayId, cache);
} }
} catch { } catch (e) {
console.warn(`Failed to process day cache: ${cacheUrl}`); console.warn(`Failed or skipped processing day cache: ${cacheUrl}`, e);
} }
// Aggregate fetch requests // Aggregate fetch requests