RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More premature optimization (1)

pull/37/head
Varun Patil 2022-09-12 09:33:46 -07:00
parent cc630f9ea9
commit 540b80f1e0
5 changed files with 31 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/memories-main.js
View File

File diff suppressed because one or more lines are too long

2
js/memories-main.js.map
View File

File diff suppressed because one or more lines are too long

3
src/components/Photo.vue
View File

@ -71,6 +71,9 @@ export default {
return undefined;
} else if (this.data.flag & constants.FLAG_LOAD_FAIL) {
return errorsvg;
} else if (this.data.flag & constants.FLAG_FORCE_RELOAD) {
this.data.flag &= ~constants.FLAG_FORCE_RELOAD;
return undefined;
} else {
return getPreviewUrl(this.data.fileid, this.data.etag);
}

37
src/components/Timeline.vue
View File

@ -347,10 +347,27 @@ export default {
// Reset image state
for (let i = startIndex; i < endIndex; i++) {
if ((i < this.currentStart || i > this.currentEnd) && this.list[i].photos) {
this.list[i].photos.forEach(photo => {
photo.l = 0;
});
const row = this.list[i];
if (!row) {
continue;
}
// Initialize photos and add placeholders
if (row.pct && !row.photos.length) {
row.photos = new Array(row.pct);
for (let j = 0; j < row.pct; j++) {
row.photos[j] = {
flag: constants.FLAG_PLACEHOLDER,
fileid: `${row.dayId}-${i}-${j}`,
};
}
delete row.pct;
}
if ((i < this.currentStart || i > this.currentEnd) && row.photos) {
for (const photo of row.photos) {
photo.flag = (photo.flag & ~constants.FLAG_LOADED) | constants.FLAG_FORCE_RELOAD;
}
}
}
@ -468,16 +485,10 @@ export default {
list.push(row);
day.rows.add(row);
// Add placeholders
// Add placeholder count
const leftNum = (day.count - i * this.numCols);
const rowCount = leftNum > this.numCols ? this.numCols : leftNum;
row.photos = new Array(rowCount);
for (let j = 0; j < rowCount; j++) {
row.photos[j] = {
flag: constants.FLAG_PLACEHOLDER,
fileid: `${day.dayid}-${i}-${j}`,
};
}
row.pct = leftNum > this.numCols ? this.numCols : leftNum;
row.photos = [];
}
}

1
src/mixins/constants.js
View File

@ -8,4 +8,5 @@ export default {
FLAG_LEAVING: 1 << 6,
FLAG_EXIT_LEFT: 1 << 7,
FLAG_ENTER_RIGHT: 1 << 8,
FLAG_FORCE_RELOAD: 1 << 9,
};