RPJosh
/
memories
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

video: fix lp playback on Safari 

Signed-off-by: Varun Patil <radialapps@gmail.com>
monorepo
Varun Patil 2023-10-31 13:04:02 -07:00
parent 7020d0ddac
commit 3374508920
1 changed files with 59 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
lib/Controller/VideoController.php
View File

@ -273,18 +273,22 @@ class VideoController extends GenericApiController
// Catch connection abort here
ignore_user_abort(true);
// Stream the response to the browser without reading it into memory
$headersWritten = false;
curl_setopt($ch, CURLOPT_WRITEFUNCTION, static function (mixed $curl, mixed $data) use (&$headersWritten, $profile) {
$returnCode = (int) curl_getinfo($curl, CURLINFO_HTTP_CODE);
if (200 === $returnCode) {
$headerswritten = false;
$sendheaders = static function (\CurlHandle $curl) use (&$headerswritten, $profile): void {
// Write headers if just got the first chunk of data
if (!$headersWritten) {
$headersWritten = true;
if ($headerswritten) {
return;
}
$headerswritten = true;
// Pass ahead response code
http_response_code((int) curl_getinfo($curl, CURLINFO_HTTP_CODE));
// Pass ahead content type
$contentType = curl_getinfo($curl, CURLINFO_CONTENT_TYPE);
header("Content-Type: {$contentType}");
// Caching headers
if (str_ends_with($profile, 'mp4')) {
// cache full video 24 hours
header('Cache-Control: max-age=86400, public');
@ -292,13 +296,27 @@ class VideoController extends GenericApiController
// no caching of segments
header('Cache-Control: no-cache, no-store, must-revalidate');
}
};
http_response_code($returnCode);
}
// On Safari with MP4, chunked transfer encoding is not supported
// So we need to read the whole file into memory and send it
$userAgent = $this->request->getHeader('User-Agent');
$isSafari = preg_match('/^((?!chrome|android).)*safari/i', $userAgent);
if (!$isSafari) {
// Stream the response to the browser without reading it into memory
curl_setopt($ch, CURLOPT_WRITEFUNCTION, static function (\CurlHandle $curl, string $data) use (&$sendheaders) {
$code = (int) curl_getinfo($curl, CURLINFO_HTTP_CODE);
if (200 === $code) {
// Write headers if not done yet
$sendheaders($curl);
// Chunked transfer encoding
echo $data;
flush();
// Check if the client is still connected
if (connection_aborted()) {
return -1; // stop the transfer
}
@ -306,9 +324,18 @@ class VideoController extends GenericApiController
return \strlen($data);
});
}
// Start the request
curl_exec($ch);
$response = curl_exec($ch);
// Send the entire response if Safari
if ($isSafari && \is_string($response)) {
$sendheaders($ch);
header('Content-Length: '.\strlen($response)); // critical
echo $response;
}
$returnCode = (int) curl_getinfo($ch, CURLINFO_HTTP_CODE);
curl_close($ch);