refactor: move rowHead to comp

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

src/components/Timeline.vue

@@ -45,21 +45,12 @@
       </template>
 
       <template v-slot="{ item, index }">
-        <div
+        <RowHead
           v-if="item.type === 0"
-          :key="item.id"
+          :item="item"
-          :style="{ height: `${item.size}px` }"
+          :monthView="isMonthView"
-          :class="{ selected: item.selected }"
+          @click="selectionManager.selectHead(item)"
-          class="head-row"
+        />
-        >
-          <div class="super" v-if="item.super !== undefined">
-            {{ item.super }}
-          </div>
-          <div class="main" @click="selectionManager.selectHead(item)">
-            <CheckCircle v-once :size="20" class="select" />
-            <span class="name"> {{ item.name || getHeadName(item) }} </span>
-          </div>
-        </div>
 
         <Photo
           class="photo"
@@ -123,6 +114,7 @@ import { IDay, IFolder, IHeadRow, IPhoto, IRow, IRowType } from "../types";
 
 import UserConfig from "../mixins/UserConfig";
 import FolderGrid from "./FolderGrid.vue";
+import RowHead from "./frame/RowHead.vue";
 import Photo from "./frame/Photo.vue";
 import ScrollerManager from "./ScrollerManager.vue";
 import SelectionManager from "./SelectionManager.vue";
@@ -136,7 +128,6 @@ import * as dav from "../services/DavRequests";
 import * as utils from "../services/Utils";
 import * as strings from "../services/strings";
 
-import CheckCircle from "vue-material-design-icons/CheckCircle.vue";
 import { API, DaysFilterType } from "../services/API";
 
 const SCROLL_LOAD_DELAY = 250; // Delay in loading data when scrolling
@@ -149,6 +140,7 @@ export default defineComponent({
 
   components: {
     FolderGrid,
+    RowHead,
     Photo,
     EmptyContent,
     OnThisDay,
@@ -156,8 +148,6 @@ export default defineComponent({
     SelectionManager,
     ScrollerManager,
     Viewer,
-
-    CheckCircle,
   },
 
   mixins: [UserConfig],
@@ -676,29 +666,6 @@ export default defineComponent({
       return query;
     },
 
-    /** Get name of header */
-    getHeadName(head: IHeadRow) {
-      // Check cache
-      if (head.name) {
-        return head.name;
-      }
-
-      // Make date string
-      // The reason this function is separate from processDays is
-      // because this call is terribly slow even on desktop
-      const dateTaken = utils.dayIdToDate(head.dayId);
-      let name: string;
-      if (this.isMonthView) {
-        name = utils.getMonthDateStr(dateTaken);
-      } else {
-        name = utils.getLongDateStr(dateTaken, true);
-      }
-
-      // Cache and return
-      head.name = name;
-      return head.name;
-    },
-
     /** Fetch folders */
     async fetchFolders() {
       if (!this.routeIsFolders || this.$route.query.recursive) {
@@ -1299,12 +1266,6 @@ export default defineComponent({
 </script>
 
 <style lang="scss" scoped>
-@mixin phone {
-  @media (max-width: 768px) {
-    @content;
-  }
-}
-
 /** Main view */
 .container {
   height: 100%;
@@ -1357,63 +1318,6 @@ export default defineComponent({
     transform 0.2s ease-in-out; // reflow
 }
 
-.head-row {
-  contain: strict;
-  padding-top: 10px;
-  padding-left: 3px;
-  font-size: 0.9em;
-
-  > div {
-    position: relative;
-    &.super {
-      font-size: 1.4em;
-      font-weight: bold;
-      margin-bottom: 4px;
-    }
-    &.main {
-      display: inline-block;
-      font-weight: 600;
-    }
-  }
-
-  .select {
-    position: absolute;
-    left: 0;
-    top: 50%;
-    display: none;
-    opacity: 0;
-    transform: translateY(-45%);
-    transition: opacity 0.2s ease;
-    border-radius: 50%;
-    cursor: pointer;
-  }
-  .name {
-    display: block;
-    transition: transform 0.2s ease;
-    cursor: pointer;
-    font-size: 1.075em;
-  }
-
-  :hover,
-  &.selected {
-    .select {
-      display: flex;
-      opacity: 0.7;
-    }
-    .name {
-      transform: translateX(24px);
-    }
-  }
-  &.selected .select {
-    opacity: 1;
-    color: var(--color-primary);
-  }
-
-  @include phone {
-    transform: translateX(8px);
-  }
-}
-
 /** Dynamic top matter */
 .recycler-before {
   width: 100%;
@@ -1421,7 +1325,7 @@ export default defineComponent({
     font-size: 1.2em;
     padding-top: 13px;
     padding-left: 8px;
-    @include phone {
+    @media (max-width: 768px) {
       padding-left: 48px;
     }
   }

src/components/frame/RowHead.vue

@@ -0,0 +1,132 @@
+<template>
+  <div
+    class="head-row"
+    :class="{ selected: item.selected }"
+    :style="{ height: `${item.size}px` }"
+  >
+    <div class="super" v-if="item.super !== undefined">
+      {{ item.super }}
+    </div>
+    <div class="main" @click="click">
+      <CheckCircle v-once :size="20" class="select" />
+      <span class="name"> {{ name }} </span>
+    </div>
+  </div>
+</template>
+
+<script lang="ts">
+import { defineComponent, PropType } from "vue";
+import { IHeadRow } from "../../types";
+
+import CheckCircle from "vue-material-design-icons/CheckCircle.vue";
+
+import * as utils from "../../services/Utils";
+
+export default defineComponent({
+  name: "RowHead",
+
+  components: {
+    CheckCircle,
+  },
+
+  props: {
+    item: {
+      type: Object as PropType<IHeadRow>,
+      required: true,
+    },
+    monthView: {
+      type: Boolean,
+      required: true,
+    },
+  },
+
+  computed: {
+    name() {
+      // Check cache
+      if (this.item.name) {
+        return this.item.name;
+      }
+
+      // Make date string
+      // The reason this function is separate from processDays is
+      // because this call is terribly slow even on desktop
+      const dateTaken = utils.dayIdToDate(this.item.dayId);
+      let name: string;
+      if (this.monthView) {
+        name = utils.getMonthDateStr(dateTaken);
+      } else {
+        name = utils.getLongDateStr(dateTaken, true);
+      }
+
+      // Cache and return
+      this.item.name = name;
+      return name;
+    },
+  },
+
+  methods: {
+    click() {
+      this.$emit("click", this.item);
+    },
+  },
+});
+</script>
+
+<style lang="scss" scoped>
+.head-row {
+  contain: strict;
+  padding-top: 10px;
+  padding-left: 3px;
+  font-size: 0.9em;
+
+  > div {
+    position: relative;
+    &.super {
+      font-size: 1.4em;
+      font-weight: bold;
+      margin-bottom: 4px;
+    }
+    &.main {
+      display: inline-block;
+      font-weight: 600;
+    }
+  }
+
+  .select {
+    position: absolute;
+    left: 0;
+    top: 50%;
+    display: none;
+    opacity: 0;
+    transform: translateY(-45%);
+    transition: opacity 0.2s ease;
+    border-radius: 50%;
+    cursor: pointer;
+  }
+  .name {
+    display: block;
+    transition: transform 0.2s ease;
+    cursor: pointer;
+    font-size: 1.075em;
+  }
+
+  :hover,
+  &.selected {
+    .select {
+      display: flex;
+      opacity: 0.7;
+    }
+    .name {
+      transform: translateX(24px);
+    }
+  }
+  &.selected .select {
+    opacity: 1;
+    color: var(--color-primary);
+  }
+
+  @media (max-width: 768px) {
+    transform: translateX(8px);
+  }
+}
+</style>