RPJosh
/
authelia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(handlers): synology password complexity err on reset (#2083) 

This responds to the client with the correct error when used with Synology LDAP servers.
pull/2087/head
James Elliott 2021-06-16 12:50:14 +10:00 committed by GitHub
parent 9e836d990c
commit fcfff9748c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/handlers/const.go
View File

@ -44,8 +44,13 @@ const mfaValidationFailedMessage = "Authentication failed, please retry later."
const ldapPasswordComplexityCode = "0000052D." const ldapPasswordComplexityCode = "0000052D."
var ldapPasswordComplexityCodes = []string{"0000052D"} var ldapPasswordComplexityCodes = []string{
var ldapPasswordComplexityErrors = []string{"LDAP Result Code 19 \"Constraint Violation\": Password fails quality checking policy"} "0000052D", "SynoNumber", "SynoMixedCase", "SynoExcludeNameDesc", "SynoSpecialChar",
}
var ldapPasswordComplexityErrors = []string{
"LDAP Result Code 19 \"Constraint Violation\": Password fails quality checking policy",
"LDAP Result Code 19 \"Constraint Violation\": Password is too young to change",
}
const testInactivity = "10" const testInactivity = "10"
const testRedirectionURL = "http://redirection.local" const testRedirectionURL = "http://redirection.local"

5
internal/handlers/handler_reset_password_step2.go
View File

@ -31,9 +31,8 @@ func ResetPasswordPost(ctx *middlewares.AutheliaCtx) {
if err != nil { if err != nil {
switch { switch {
case utils.IsStringInSliceContains(err.Error(), ldapPasswordComplexityCodes): case utils.IsStringInSliceContains(err.Error(), ldapPasswordComplexityCodes),
ctx.Error(fmt.Errorf("%s", err), ldapPasswordComplexityCode) utils.IsStringInSliceContains(err.Error(), ldapPasswordComplexityErrors):
case utils.IsStringInSliceContains(err.Error(), ldapPasswordComplexityErrors):
ctx.Error(fmt.Errorf("%s", err), ldapPasswordComplexityCode) ctx.Error(fmt.Errorf("%s", err), ldapPasswordComplexityCode)
default: default:
ctx.Error(fmt.Errorf("%s", err), unableToResetPasswordMessage) ctx.Error(fmt.Errorf("%s", err), unableToResetPasswordMessage)