From f1b3fc7b31249bc38b2795c694022036c58e89af Mon Sep 17 00:00:00 2001
From: James Elliott <james-d-elliott@users.noreply.github.com>
Date: Thu, 25 May 2023 07:58:00 +1000
Subject: [PATCH] test(handlers): add missing tests (#5480)

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
---
 .../handlers/handler_authz_builder_test.go    | 93 +++++++++++++++++++
 internal/handlers/handler_authz_misc_test.go  | 31 +++++++
 2 files changed, 124 insertions(+)
 create mode 100644 internal/handlers/handler_authz_builder_test.go
 create mode 100644 internal/handlers/handler_authz_misc_test.go

diff --git a/internal/handlers/handler_authz_builder_test.go b/internal/handlers/handler_authz_builder_test.go
new file mode 100644
index 000000000..dc4bff1fd
--- /dev/null
+++ b/internal/handlers/handler_authz_builder_test.go
@@ -0,0 +1,93 @@
+package handlers
+
+import (
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/authelia/authelia/v4/internal/configuration/schema"
+)
+
+func TestAuthzBuilder_WithConfig(t *testing.T) {
+	builder := NewAuthzBuilder()
+
+	builder.WithConfig(&schema.Configuration{
+		AuthenticationBackend: schema.AuthenticationBackend{
+			RefreshInterval: "always",
+		},
+	})
+
+	assert.Equal(t, time.Second*0, builder.config.RefreshInterval)
+
+	builder.WithConfig(&schema.Configuration{
+		AuthenticationBackend: schema.AuthenticationBackend{
+			RefreshInterval: "disable",
+		},
+	})
+
+	assert.Equal(t, time.Second*-1, builder.config.RefreshInterval)
+
+	builder.WithConfig(&schema.Configuration{
+		AuthenticationBackend: schema.AuthenticationBackend{
+			RefreshInterval: "1m",
+		},
+	})
+
+	assert.Equal(t, time.Minute, builder.config.RefreshInterval)
+
+	builder.WithConfig(nil)
+
+	assert.Equal(t, time.Minute, builder.config.RefreshInterval)
+}
+
+func TestAuthzBuilder_WithEndpointConfig(t *testing.T) {
+	builder := NewAuthzBuilder()
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "ExtAuthz",
+	})
+
+	assert.Equal(t, AuthzImplExtAuthz, builder.implementation)
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "ForwardAuth",
+	})
+
+	assert.Equal(t, AuthzImplForwardAuth, builder.implementation)
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "AuthRequest",
+	})
+
+	assert.Equal(t, AuthzImplAuthRequest, builder.implementation)
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "Legacy",
+	})
+
+	assert.Equal(t, AuthzImplLegacy, builder.implementation)
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "ExtAuthz",
+		AuthnStrategies: []schema.ServerAuthzEndpointAuthnStrategy{
+			{Name: "HeaderProxyAuthorization"},
+			{Name: "CookieSession"},
+		},
+	})
+
+	assert.Len(t, builder.strategies, 2)
+
+	builder.WithEndpointConfig(schema.ServerAuthzEndpoint{
+		Implementation: "ExtAuthz",
+		AuthnStrategies: []schema.ServerAuthzEndpointAuthnStrategy{
+			{Name: "HeaderAuthorization"},
+			{Name: "HeaderProxyAuthorization"},
+			{Name: "HeaderAuthRequestProxyAuthorization"},
+			{Name: "HeaderLegacy"},
+			{Name: "CookieSession"},
+		},
+	})
+
+	assert.Len(t, builder.strategies, 5)
+}
diff --git a/internal/handlers/handler_authz_misc_test.go b/internal/handlers/handler_authz_misc_test.go
new file mode 100644
index 000000000..ad57c21b2
--- /dev/null
+++ b/internal/handlers/handler_authz_misc_test.go
@@ -0,0 +1,31 @@
+package handlers
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/valyala/fasthttp"
+
+	"github.com/authelia/authelia/v4/internal/authentication"
+	"github.com/authelia/authelia/v4/internal/mocks"
+	"github.com/authelia/authelia/v4/internal/session"
+)
+
+func TestAuthzImplementation(t *testing.T) {
+	assert.Equal(t, "Legacy", AuthzImplLegacy.String())
+	assert.Equal(t, "", AuthzImplementation(-1).String())
+}
+
+func TestFriendlyMethod(t *testing.T) {
+	assert.Equal(t, "unknown", friendlyMethod(""))
+	assert.Equal(t, "GET", friendlyMethod(fasthttp.MethodGet))
+}
+
+func TestGenerateVerifySessionHasUpToDateProfileTraceLogs(t *testing.T) {
+	mock := mocks.NewMockAutheliaCtx(t)
+
+	generateVerifySessionHasUpToDateProfileTraceLogs(mock.Ctx, &session.UserSession{Username: "john", DisplayName: "example", Groups: []string{"abc"}, Emails: []string{"user@example.com", "test@example.com"}}, &authentication.UserDetails{Username: "john", Groups: []string{"123"}, DisplayName: "notexample", Emails: []string{"notuser@example.com"}})
+	generateVerifySessionHasUpToDateProfileTraceLogs(mock.Ctx, &session.UserSession{Username: "john", DisplayName: "example"}, &authentication.UserDetails{Username: "john", DisplayName: "example"})
+	generateVerifySessionHasUpToDateProfileTraceLogs(mock.Ctx, &session.UserSession{Username: "john", DisplayName: "example", Emails: []string{"abc@example.com"}}, &authentication.UserDetails{Username: "john", DisplayName: "example"})
+	generateVerifySessionHasUpToDateProfileTraceLogs(mock.Ctx, &session.UserSession{Username: "john", DisplayName: "example"}, &authentication.UserDetails{Username: "john", DisplayName: "example", Emails: []string{"abc@example.com"}})
+}