RPJosh
/
authelia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[CI] Update PR commentary (#1592) 

This change updates the PR commentary specifically around linting.

We now also allow users to submit PR's to Authelia from forked `master` branches as this previously caused issues with codecov.
pull/1596/head
Amir Zarrinkafsh 2021-01-12 12:21:01 +11:00 committed by GitHub
parent 6aa0e5fa7d
commit e6111f775b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
.github/probot.js vendored
View File

@ -24,7 +24,7 @@ on('pull_request.opened')
context => context =>
!context.payload.pull_request.head.label.includes(':master') !context.payload.pull_request.head.label.includes(':master')
) )
.comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}. We lint all PR's with golangci-lint, I may add a review to your PR with some suggestions. .comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}. We lint all PR's with golangci-lint and eslint, I may add a review to your PR with some suggestions.
You are free to apply the changes if you're comfortable, alternatively you are welcome to ask a team member for advice. You are free to apply the changes if you're comfortable, alternatively you are welcome to ask a team member for advice.
@ -32,19 +32,4 @@ You are free to apply the changes if you're comfortable, alternatively you are w
These changes once approved by a team member will be published for testing on Buildkite and DockerHub. These changes once approved by a team member will be published for testing on Buildkite and DockerHub.
### Docker Container ### Docker Container
* \`docker pull authelia/authelia:PR{{ pull_request.number }}\``) * \`docker pull authelia/authelia:PR{{ pull_request.number }}\``)
// PR commentary for forked master branches
on('pull_request.opened')
.filter(
context =>
context.payload.pull_request.head.label.slice(0, 9) !== 'authelia:'
)
.filter(
context =>
context.payload.pull_request.head.label.includes(':master')
)
.comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}.
Unfortunately it appears that you're submitting a PR from a forked master branch and this is known to causes issues with codecov. Please re-submit your PR from a branch other than master.`)
.close()