refactor: directly return error where sufficient (#2855)

internal/commands/root.go

@@ -120,7 +120,7 @@ func doStartupChecks(config *schema.Configuration, providers *middlewares.Provid
 	}
 }
 
-func doStartupCheck(logger *logrus.Logger, name string, provider models.StartupCheck, disabled bool) (err error) {
+func doStartupCheck(logger *logrus.Logger, name string, provider models.StartupCheck, disabled bool) error {
 	if disabled {
 		logger.Debugf("%s provider: startup check skipped as it is disabled", name)
 		return nil
@@ -130,9 +130,5 @@ func doStartupCheck(logger *logrus.Logger, name string, provider models.StartupC
 		return fmt.Errorf("unrecognized provider or it is not configured properly")
 	}
 
-	if err = provider.StartupCheck(); err != nil {
+	return provider.StartupCheck()
-		return err
-	}
-
-	return nil
 }

internal/commands/storage_run.go

@@ -33,11 +33,9 @@ func storagePersistentPreRunE(cmd *cobra.Command, _ []string) (err error) {
 
 			sources = append(sources, configuration.NewYAMLFileSource(configFile))
 		}
-	} else {
+	} else if _, err := os.Stat(configs[0]); err == nil {
-		if _, err := os.Stat(configs[0]); err == nil {
 		sources = append(sources, configuration.NewYAMLFileSource(configs[0]))
 	}
-	}
 
 	mapping := map[string]string{
 		"encryption-key": "storage.encryption_key",

internal/notification/file_notifier.go

@@ -38,22 +38,12 @@ func (n *FileNotifier) StartupCheck() (err error) {
 		}
 	}
 
-	if err := os.WriteFile(n.path, []byte(""), fileNotifierMode); err != nil {
+	return os.WriteFile(n.path, []byte(""), fileNotifierMode)
-		return err
-	}
-
-	return nil
 }
 
 // Send send a identity verification link to a user.
 func (n *FileNotifier) Send(recipient, subject, body, _ string) error {
 	content := fmt.Sprintf("Date: %s\nRecipient: %s\nSubject: %s\nBody: %s", time.Now(), recipient, subject, body)
 
-	err := os.WriteFile(n.path, []byte(content), fileNotifierMode)
+	return os.WriteFile(n.path, []byte(content), fileNotifierMode)
-
-	if err != nil {
-		return err
-	}
-
-	return nil
 }

internal/notification/smtp_notifier.go

@@ -243,11 +243,7 @@ func (n *SMTPNotifier) StartupCheck() (err error) {
 		return err
 	}
 
-	if err := n.client.Reset(); err != nil {
+	return n.client.Reset()
-		return err
-	}
-
-	return nil
 }
 
 // Send is used to send an email to a recipient.

internal/suites/utils.go

@@ -54,7 +54,7 @@ func (rs *RodSession) collectScreenshot(err error, page *rod.Page) {
 		build := os.Getenv("BUILDKITE_BUILD_NUMBER")
 		suite := strings.ToLower(os.Getenv("SUITE"))
 		job := os.Getenv("BUILDKITE_JOB_ID")
-		path := filepath.Join(fmt.Sprintf("%s/%s/%s/%s", base, build, suite, job)) //nolint: gocritic
+		path := filepath.Join(base, build, suite, job)
 
 		if err := os.MkdirAll(path, 0755); err != nil {
 			log.Fatal(err)