From 56c10eab76745a484b1f1d43f6db0e504e8a5c0a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Manuel=20Nu=C3=B1ez?=
 <10672208+mind-ar@users.noreply.github.com>
Date: Thu, 13 Apr 2023 08:15:28 -0300
Subject: [PATCH] test(configuration): add additional coverage (#4779)

---
 internal/configuration/provider_test.go | 70 +++++++++++++++++++++++++
 internal/configuration/template_test.go | 17 ++++++
 2 files changed, 87 insertions(+)

diff --git a/internal/configuration/provider_test.go b/internal/configuration/provider_test.go
index f91b9629b..6c1658948 100644
--- a/internal/configuration/provider_test.go
+++ b/internal/configuration/provider_test.go
@@ -401,6 +401,9 @@ func TestShouldNotReadConfigurationOnFSAccessDenied(t *testing.T) {
 func TestShouldLoadDirectoryConfiguration(t *testing.T) {
 	dir := t.TempDir()
 
+	cfg := filepath.Join(dir, "myconf.yml")
+	assert.NoError(t, testCreateFile(cfg, "server:\n  port: 9091\n", 0700))
+
 	val := schema.NewStructValidator()
 	_, _, err := Load(val, NewFileSource(dir))
 
@@ -416,3 +419,70 @@ func testSetEnv(t *testing.T, key, value string) {
 func testCreateFile(path, value string, perm os.FileMode) (err error) {
 	return os.WriteFile(path, []byte(value), perm)
 }
+
+func TestShouldErrorOnNoPath(t *testing.T) {
+	val := schema.NewStructValidator()
+	_, _, err := Load(val, NewFileSource(""))
+
+	assert.NoError(t, err)
+	assert.Len(t, val.Errors(), 1)
+	assert.ErrorContains(t, val.Errors()[0], "invalid file path source configuration")
+}
+
+func TestShouldErrorOnInvalidPath(t *testing.T) {
+	dir := t.TempDir()
+	cfg := filepath.Join(dir, "invalid-folder/config")
+
+	val := schema.NewStructValidator()
+	_, _, err := Load(val, NewFileSource(cfg))
+
+	assert.NoError(t, err)
+	assert.Len(t, val.Errors(), 1)
+	assert.ErrorContains(t, val.Errors()[0], fmt.Sprintf("stat %s: no such file or directory", cfg))
+}
+
+func TestShouldErrorOnDirFSPermissionDenied(t *testing.T) {
+	if runtime.GOOS == constWindows {
+		t.Skip("skipping test due to being on windows")
+	}
+
+	dir := t.TempDir()
+	err := os.Chmod(dir, 0200)
+	assert.NoError(t, err)
+
+	val := schema.NewStructValidator()
+	_, _, err = Load(val, NewFileSource(dir))
+
+	assert.NoError(t, err)
+	assert.Len(t, val.Errors(), 1)
+	assert.ErrorContains(t, val.Errors()[0], fmt.Sprintf("open %s: permission denied", dir))
+}
+
+func TestShouldSkipDirOnLoad(t *testing.T) {
+	dir := t.TempDir()
+	path := filepath.Join(dir, "some-dir")
+
+	err := os.Mkdir(path, 0700)
+	assert.NoError(t, err)
+
+	val := schema.NewStructValidator()
+	_, _, err = Load(val, NewFileSource(dir))
+
+	assert.NoError(t, err)
+	assert.Len(t, val.Errors(), 0)
+	assert.Len(t, val.Warnings(), 0)
+}
+
+func TestShouldFailIfYmlIsInvalid(t *testing.T) {
+	dir := t.TempDir()
+
+	cfg := filepath.Join(dir, "myconf.yml")
+	assert.NoError(t, testCreateFile(cfg, "an invalid contend\n", 0700))
+
+	val := schema.NewStructValidator()
+	_, _, err := Load(val, NewFileSource(dir))
+
+	assert.NoError(t, err)
+	assert.Len(t, val.Errors(), 1)
+	assert.ErrorContains(t, val.Errors()[0], "unmarshal errors")
+}
diff --git a/internal/configuration/template_test.go b/internal/configuration/template_test.go
index 3be14868f..aab4b26ae 100644
--- a/internal/configuration/template_test.go
+++ b/internal/configuration/template_test.go
@@ -25,6 +25,23 @@ func TestShouldGenerateConfiguration(t *testing.T) {
 	assert.NoError(t, err)
 }
 
+func TestNotShouldGenerateConfigurationifExists(t *testing.T) {
+	dir := t.TempDir()
+
+	cfg := filepath.Join(dir, "config.yml")
+
+	created, err := EnsureConfigurationExists(cfg)
+	assert.NoError(t, err)
+	assert.True(t, created)
+
+	created, err = EnsureConfigurationExists(cfg)
+	assert.NoError(t, err)
+	assert.False(t, created)
+
+	_, err = os.Stat(cfg)
+	assert.NoError(t, err)
+}
+
 func TestShouldNotGenerateConfigurationOnFSAccessDenied(t *testing.T) {
 	if runtime.GOOS == constWindows {
 		t.Skip("skipping test due to being on windows")