From 03d56a31add0d5b84f63028a26dba8ecbc683ea1 Mon Sep 17 00:00:00 2001 From: James Elliott Date: Fri, 8 Jul 2022 20:56:22 +1000 Subject: [PATCH] refactor: address code review (#3675) Addresses code review for #3653. --- internal/configuration/decode_hooks_test.go | 1 - internal/configuration/schema/types.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/configuration/decode_hooks_test.go b/internal/configuration/decode_hooks_test.go index dc2eca84d..cbf653394 100644 --- a/internal/configuration/decode_hooks_test.go +++ b/internal/configuration/decode_hooks_test.go @@ -774,7 +774,6 @@ func TestStringToAddressHookFunc(t *testing.T) { expected interface{} err string decode bool - wantGrps []string }{ { name: "ShouldDecodeNonPtr", diff --git a/internal/configuration/schema/types.go b/internal/configuration/schema/types.go index dc3bc3bb8..5fb6de70e 100644 --- a/internal/configuration/schema/types.go +++ b/internal/configuration/schema/types.go @@ -52,7 +52,7 @@ func NewAddressFromURL(u *url.URL) (addr *Address, err error) { } switch addr.Scheme { - case "tcp", "udp", "http", "https": + case "tcp", "udp": break default: return nil, fmt.Errorf("could not parse scheme for address '%s': scheme '%s' is not valid, expected to be one of 'tcp://', 'udp://'", u.String(), addr.Scheme)