refactor: style issue

include/ALabel.hpp

@@ -8,7 +8,7 @@ namespace waybar {
 class ALabel : public IModule {
   public:
     ALabel(Json::Value);
-    virtual ~ALabel();
+    virtual ~ALabel() = default;
     virtual auto update() -> void;
     virtual operator Gtk::Widget &();
   protected:

include/modules/custom.hpp

@@ -11,7 +11,7 @@ class Custom : public ALabel {
     Custom(const std::string&, Json::Value);
     auto update() -> void;
   private:
-    const std::string name_;
+    const std::string& name_;
     waybar::util::SleeperThread thread_;
 };
 

src/ALabel.cpp

@@ -9,11 +9,6 @@ waybar::ALabel::ALabel(Json::Value config)
   }
 }
 
-waybar::ALabel::~ALabel()
-{
-  // Nothing here
-}
-
 auto waybar::ALabel::update() -> void
 {
   // Nothing here

src/client.cpp

@@ -81,7 +81,7 @@ void waybar::Client::bindInterfaces()
 int waybar::Client::main(int /*argc*/, char* /*argv*/[])
 {
   bindInterfaces();
-  gtk_main.run();
+  Gtk::Main::run();
   bars.clear();
   zxdg_output_manager_v1_destroy(xdg_output_manager);
   zwlr_layer_shell_v1_destroy(layer_shell);

src/modules/battery.cpp

@@ -16,7 +16,7 @@ waybar::modules::Battery::Battery(Json::Value config)
   if (batteries_.empty()) {
     throw std::runtime_error("No batteries.");
   }
-  auto fd = inotify_init();
+  auto fd = inotify_init1(IN_CLOEXEC);
   if (fd == -1) {
     throw std::runtime_error("Unable to listen batteries.");
   }

src/modules/cpu.cpp

@@ -15,7 +15,7 @@ auto waybar::modules::Cpu::update() -> void
 {
   struct sysinfo info = {0};
   if (sysinfo(&info) == 0) {
-    float f_load = 1.f / (1U << SI_LOAD_SHIFT);
+    float f_load = 1.f / (1u << SI_LOAD_SHIFT);
     uint16_t load = info.loads[0] * f_load * 100 / get_nprocs();
     auto format = config_["format"] ? config_["format"].asString() : "{}%";
     label_.set_text(fmt::format(format, load));

src/modules/network.cpp

@@ -234,9 +234,9 @@ int waybar::modules::Network::getExternalInterface()
   } while (true);
 
 out:
-  if (req)
+  if (req != nullptr)
     free(req);
-  if (resp)
+  if (resp != nullptr)
     free(resp);
   return ifidx;
 }