RPJosh
/
Waybar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(modules/mpris): fix on-*-click typos 

In all other places, the norm is to use `on-click-(middle|right)` but in
the mpris module, `on-(middle|right)-click` was being used which caused
clicks to malfunction if set to some custom commands
pull/2560/head
Akshett Rai Jindal 2023-10-09 11:48:49 +05:30
parent 30cc88a4c5
commit 1af02e0a67
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
man/waybar-mpris.5.scd
View File

@ -126,12 +126,12 @@ The *mpris* module displays currently playing media via libplayerctl.
default: play-pause ++ default: play-pause ++
Overwrite default action toggles. Overwrite default action toggles.
*on-middle-click*: ++ *on-click-middle*: ++
typeof: string ++ typeof: string ++
default: previous track ++ default: previous track ++
Overwrite default action toggles. Overwrite default action toggles.
*on-right-click*: ++ *on-click-right*: ++
typeof: string ++ typeof: string ++
default: next track ++ default: next track ++
Overwrite default action toggles. Overwrite default action toggles.

4
src/modules/mpris/mpris.cpp
View File

@ -587,13 +587,13 @@ bool Mpris::handleToggle(GdkEventButton* const& e) {
playerctl_player_play_pause(player, &error); playerctl_player_play_pause(player, &error);
break; break;
case 2: // middle-click case 2: // middle-click
if (config_["on-middle-click"].isString()) { if (config_["on-click-middle"].isString()) {
return ALabel::handleToggle(e); return ALabel::handleToggle(e);
} }
playerctl_player_previous(player, &error); playerctl_player_previous(player, &error);
break; break;
case 3: // right-click case 3: // right-click
if (config_["on-right-click"].isString()) { if (config_["on-click-right"].isString()) {
return ALabel::handleToggle(e); return ALabel::handleToggle(e);
} }
playerctl_player_next(player, &error); playerctl_player_next(player, &error);