RPJosh
/
Waybar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

explicitly checking for errors to silence unused variable warnings when writing to fd

pull/1312/head
mazunki 2021-11-09 18:38:07 +01:00
parent b511103fd9
commit 17bb5643ae
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/util/command.hpp
View File

@ -68,7 +68,9 @@ inline int close(FILE* fp, pid_t pid) {
inline FILE* open(const std::string& cmd, int& pid) { inline FILE* open(const std::string& cmd, int& pid) {
if (cmd == "") return nullptr; if (cmd == "") return nullptr;
int fd[2]; int fd[2];
pipe(fd); if (pipe(fd) != 0){
throw std::runtime_error("Couldn't open a file descriptor");
}
pid_t child_pid = fork(); pid_t child_pid = fork();

8
src/modules/sway/ipc/client.cpp
View File

@ -14,12 +14,16 @@ Ipc::~Ipc() {
if (fd_ > 0) { if (fd_ > 0) {
// To fail the IPC header // To fail the IPC header
write(fd_, "close-sway-ipc", 14); if (write(fd_, "close-sway-ipc", 14) == -1) {
std::runtime_error("Couldn't close Sway IPC through fd");
}
close(fd_); close(fd_);
fd_ = -1; fd_ = -1;
} }
if (fd_event_ > 0) { if (fd_event_ > 0) {
write(fd_event_, "close-sway-ipc", 14); if (write(fd_event_, "close-sway-ipc", 14) == -1) {
std::runtime_error("Couldn't close Sway IPC through fd_event");
}
close(fd_event_); close(fd_event_);
fd_event_ = -1; fd_event_ = -1;
} }